Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added options for Reporting Plugins to README #492

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

m0g3ns
Copy link
Contributor

@m0g3ns m0g3ns commented Jan 31, 2024

Closes #491

I added usage examples for reporting plugins to example configurations and the list of available reporting plugins.
This should simplify the usage of the tool so users do not have to look in the source files of the plugins to understand how they work.

@xydesa xydesa closed this Jan 31, 2024
@xydesa xydesa reopened this Jan 31, 2024
README.md Show resolved Hide resolved
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2522518) 100.00% compared to head (d3490ca) 96.62%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #492      +/-   ##
===========================================
- Coverage   100.00%   96.62%   -3.38%     
===========================================
  Files           59       59              
  Lines         3378     3378              
===========================================
- Hits          3378     3264     -114     
- Misses           0      114     +114     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xydesa
Copy link
Collaborator

xydesa commented Jan 31, 2024

@denewiler it seems like the action failures in here might also be occuring in main: https://github.com/sscpac/statick/actions/runs/7732454334/job/21082413604

@denewiler
Copy link
Collaborator

The same unit test is failing in main and in this PR branch. Locally I ran statick against this branch (since that step gets skipped in workflows due to the failing unit test) and it passed. I'm good merging this and fixing the unit test separately.

@denewiler
Copy link
Collaborator

One addition I would like to see is an updated changelog. I'm fine if we do that ourselves before the next release.

@tdenewiler
Copy link
Contributor

#493 created to fix unit test.

@xydesa xydesa merged commit 3df6304 into sscpac:main Feb 2, 2024
3 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add reporting plugins example to README
4 participants