Skip to content

Commit

Permalink
cmake/arrow: don't treat warnings as errors
Browse files Browse the repository at this point in the history
with arrow's default BUILD_WARNING_LEVEL, -Werror is added to cflags and
debug builds fail on a warning about _FORTIFY_SOURCE

Fixes: https://tracker.ceph.com/issues/63130

Signed-off-by: Casey Bodley <[email protected]>
  • Loading branch information
cbodley committed Jan 24, 2024
1 parent f4758e5 commit 5c1a57a
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions cmake/modules/BuildArrow.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,9 @@ function(build_arrow)
else()
list(APPEND arrow_CMAKE_ARGS -DCMAKE_BUILD_TYPE=Release)
endif()
# don't add -Werror or debug package builds fail with:
#warning _FORTIFY_SOURCE requires compiling with optimization (-O)
list(APPEND arrow_CMAKE_ARGS -DBUILD_WARNING_LEVEL=PRODUCTION)

# we use an external project and copy the sources to bin directory to ensure
# that object files are built outside of the source tree.
Expand Down

0 comments on commit 5c1a57a

Please sign in to comment.