fix: Don't clear image tag

Just because you've augmented an image with a new property (digest) doesn't mean you get to clear a different value (tag) in the setter. Signed-off-by: Philipp Belitz <[email protected]>
sse-secure-systems · Nov 25, 2022 · ba35976 · ba35976
1 parent ad0ce79
commit ba35976
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/connaisseur/image.py b/connaisseur/image.py
@@ -69,7 +69,6 @@ def set_digest(self, digest):
         Set the digest to the given `digest`.
         """
         self.digest = digest
-        self.tag = None
 
     def has_digest(self) -> bool:
         """

diff --git a/tests/test_image.py b/tests/test_image.py
@@ -128,13 +128,20 @@ def test_image(
 
 
 @pytest.mark.parametrize(
-    "image, digest",
-    [("image:tag", "859b5aada817b3eb53410222e8fc232cf126c9e598390ae61895eb96f52ae46d")],
+    "image, tag, digest",
+    [
+        (
+            "image:tag",
+            "tag",
+            "859b5aada817b3eb53410222e8fc232cf126c9e598390ae61895eb96f52ae46d",
+        )
+    ],
 )
-def test_set_digest(image: str, digest: str):
+def test_set_digest(image: str, tag: str, digest: str):
     i = img.Image(image)
     i.set_digest(digest)
     assert i.digest == digest
+    assert i.tag == tag
 
 
 @pytest.mark.parametrize(