Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: unified testimages #1697

Merged
merged 1 commit into from
Jul 26, 2024
Merged

test: unified testimages #1697

merged 1 commit into from
Jul 26, 2024

Conversation

phbelitz
Copy link
Member

Unified the building process of all testimages to avoid unnecessary code duplication.

Checklist

  • PR is rebased to/aimed at branch develop
  • PR follows Contributing Guide
  • Added tests (if necessary)
  • Extended README/Documentation (if necessary)
  • Adjusted versions of image and Helm chart in Chart.yaml (if necessary)

Makefile Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.00%. Comparing base (1562cd9) to head (180d77e).
Report is 27 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1697      +/-   ##
===========================================
- Coverage    88.08%   84.00%   -4.08%     
===========================================
  Files           36       42       +6     
  Lines         2509     2939     +430     
===========================================
+ Hits          2210     2469     +259     
- Misses         255      404     +149     
- Partials        44       66      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Unified the building process of all testimages to avoid unnecessary code duplication.
@phbelitz phbelitz merged commit a9d0360 into develop Jul 26, 2024
51 checks passed
@phbelitz phbelitz deleted the test/rework/testimages branch July 26, 2024 11:01
@phbelitz phbelitz mentioned this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants