Fix: add tag labels to patch output #833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original behaviour input: 999999999999.dkr.ecr.ap-west-7.amazonaws.com/repo-alice/image-bob:v0.0.1 output: 999999999999.dkr.ecr.ap-west-7.amazonaws.com/repo-alice/image-bob@sha256:01aaa1a11aa11011a1a01a1111a11a1aaaa0aa1aa1a1a1aa1a11a0111a11a New behaviour: input: 999999999999.dkr.ecr.ap-west-7.amazonaws.com/repo-alice/image-bob:v0.0.1 output: 999999999999.dkr.ecr.ap-west-7.amazonaws.com/repo-alice/image-bob:v0.0.1@sha256:01aaa1a11aa11011a1a01a1111a11a1aaaa0aa1aa1a1a1aa1a11a0111a11a Previously, the mutating webhook would mutilate the human-readable portion of the image identifier, and patch the images in a deployment with the validated sha string. This led to angry humans who appreciated the validation and the trust of the mutation, but not the loss of the human-readable portion which is used in metrics, in observability suites, in kubectl output, and numerous other things that human beings care about. NB
implicit line join
aravandi
approved these changes
Nov 28, 2022
|
Closing in favor of #763 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # n/a
Extends: #800
Description
The mutating controller is stripping the human-readable element from the patch, and therefore the deployment artifacts that are mutated.
This results in pain and frustration for humans and tools that are relying on the human-readable element. This includes
kubectloutput, metrics tools likegrafanadashboards that have suddenly lost tag elements, security monitoring tools that can no longer see the deployed version by parsing a tag, and many more.Essentially, we will have to select a different tool and move away from
connaisseurif the image tags can not be preserved.Chainguardallegedly handles tags the way that I desire.Checklist
developvalues.yamlandChart.yaml(if necessary)