-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow feature independent stratifications in $key_join_features
#203
Merged
+118
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17ab2b2
to
21b59d0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
==========================================
+ Coverage 88.44% 88.50% +0.05%
==========================================
Files 18 18
Lines 1203 1209 +6
==========================================
+ Hits 1064 1070 +6
Misses 139 139 ☔ View full report in Codecov by Sentry. |
6197244
to
ed294db
Compare
5dd6b34
to
17b3e91
Compare
SofiaOtero
approved these changes
Feb 26, 2025
… stratification But make it in such a way that feature-independent computations still work
BREAKING CHANGE: Character input now formally disallowed
Loading status checks…
…computation Co-authored-by: Sofia Myrup Otero <[email protected]>
431ad24
to
e7f180d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
This PR removes a error message that blocks a specific use-case needed for
diseasy
.Specifically, if you have stratifications like
then,
diseasystore
will currently throw an error since no features are included in the computation.This PR removes this error
Approach
We now try to perform the grouping at the stratification level and then check if an error is produced.
Also, I had to fully deprecate non-
rlang::quos()
stratifications.The documentation has specified to use
rlang::quos()
for a while but we still allowed it -- that is no longer the caseKnown issues
N/A
Checklist
NEWS.md