Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add active binding for observable_regex #204

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

RasmusSkytte
Copy link
Contributor

@RasmusSkytte RasmusSkytte commented Jan 30, 2025

Intent

Fixes #201

Approach

N/A

Known issues

N/A

Checklist

  • The PR passes all local unit tests
  • I have documented any new features introduced
  • If the PR adds a new feature, please add an entry in NEWS.md
  • A reviewer is assigned to this PR

@RasmusSkytte RasmusSkytte self-assigned this Jan 30, 2025
@RasmusSkytte RasmusSkytte added the enhancement New feature or request label Jan 30, 2025
@RasmusSkytte RasmusSkytte added this to the v0.3.1 milestone Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.51%. Comparing base (a87b82c) to head (aa2b25b).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #204   +/-   ##
=======================================
  Coverage   88.51%   88.51%           
=======================================
  Files          18       18           
  Lines        1202     1202           
=======================================
  Hits         1064     1064           
  Misses        138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RasmusSkytte RasmusSkytte requested review from a team, kaare-gr, SofiaOtero and LasseEngboChr and removed request for a team January 30, 2025 11:42
@RasmusSkytte RasmusSkytte force-pushed the feature/public-observable_regex branch from b104b85 to 7f50203 Compare February 19, 2025 12:15
@RasmusSkytte RasmusSkytte force-pushed the feature/public-observable_regex branch from 7f50203 to aa2b25b Compare February 20, 2025 07:47
@RasmusSkytte RasmusSkytte merged commit 5f89508 into main Feb 26, 2025
28 checks passed
@RasmusSkytte RasmusSkytte deleted the feature/public-observable_regex branch February 26, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEATURE: Make observables_regex public
2 participants