Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues from CRAN manual inspection #95

Merged
merged 6 commits into from
Dec 19, 2023
Merged

Fix issues from CRAN manual inspection #95

merged 6 commits into from
Dec 19, 2023

Conversation

RasmusSkytte
Copy link
Contributor

Intent

The CRAN submission process highlighted a few minor issues. These are fixed here.

Approach

  • Some formatting changes

  • tempdir() used to write files rather than package folder (still optionally available)

  • \dontrun in %.% example replaced with commented-out code

Known issues

N/A

Checklist

  • The PR passes all local unit tests
  • I have documented any new features introduced
  • If the PR adds a new feature, please add an entry in NEWS.md
  • A reviewer is assigned to this PR

@RasmusSkytte RasmusSkytte self-assigned this Dec 19, 2023
@RasmusSkytte
Copy link
Contributor Author

Like with #93, the changes in this PR are so minor they do not merit a PR.
I created this PR to get the testing feedback from our CI tests so that I can submit to CRAN.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c5a86f) 96.77% compared to head (36de3b9) 96.77%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   96.77%   96.77%           
=======================================
  Files          12       12           
  Lines         590      590           
=======================================
  Hits          571      571           
  Misses         19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RasmusSkytte RasmusSkytte marked this pull request as ready for review December 19, 2023 10:11
@RasmusSkytte RasmusSkytte merged commit 9eee8e3 into main Dec 19, 2023
32 of 34 checks passed
@RasmusSkytte RasmusSkytte deleted the rc-v0.1 branch December 22, 2023 09:01
@RasmusSkytte RasmusSkytte mentioned this pull request Feb 1, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant