Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve margin and padding in card #428

Closed
wants to merge 1 commit into from

Conversation

Ayush9951
Copy link
Contributor

@Ayush9951 Ayush9951 commented Jun 8, 2023

close #423
Hi @raj03kumar, I've Improved padding and margin of the card, please check

Screenshot 2023-06-08 142545

@netlify
Copy link

netlify bot commented Jun 8, 2023

Deploy Preview for harmonious-stardust-e06cab ready!

Name Link
🔨 Latest commit cc0a40e
🔍 Latest deploy log https://app.netlify.com/sites/harmonious-stardust-e06cab/deploys/648197c07fbde70007063a85
😎 Deploy Preview https://deploy-preview-428--harmonious-stardust-e06cab.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@raj03kumar raj03kumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one issue with this PR. The game number get's hidden because of increased margin and padding. We can't merge this PR.

@raj03kumar
Copy link
Collaborator

There is one issue with this PR. The game number get's hidden because of increased margin and padding. We can't merge this PR.

Make changes so that the position of the number remains fixed in the card. Rest everything is good.

@Ayush9951
Copy link
Contributor Author

card doesn't have enough padding to add a game number, any suggestions

@raj03kumar
Copy link
Collaborator

card doesn't have enough padding to add a game number, any suggestions

leave it

@raj03kumar raj03kumar closed this Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update card UI
2 participants