Fixed issue #452

[Pranav-Rustagi]

No description provided.

[netlify]

✅ Deploy Preview for harmonious-stardust-e06cab ready!

Name	Link
🔨 Latest commit	067a781
🔍 Latest deploy log	https://app.netlify.com/sites/harmonious-stardust-e06cab/deploys/6489eadfff0bfe00074a10e2
😎 Deploy Preview	https://deploy-preview-492--harmonious-stardust-e06cab.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[raj03kumar]

@panwar8279 This was an invalid PR. Please review it properly before merging the PR's.
And you assigned this person labels as well. Please review properly @panwar8279 .

I see you are working with full commitment @panwar8279 but please check the work thoroughly before merging.

[raj03kumar]

@panwar8279 I shall walk you through the steps before merging any PR.

• First check the deployment website. You can see that from here.
  
• If you really think the changes are made accordingly then only merge.
• Also go through the files changed to catch the invalid PR's
  
• If you think that it is invalid then don't merge it.
• If you see that it is made using just HTML, CSS and JS without React Framework then also don't merge it.

Hope you understand us and work accordingly. We are so happy working with you @panwar8279 . Appreciate your hard work.

[Pranav-Rustagi]

@raj03kumar May I please ask how it is an invalid PR? Are the PRs supposed to be strictly React JS based, since this issue was regarding the deployment?

[raj03kumar]

@raj03kumar May I please ask how it is an invalid PR? Are the PRs supposed to be strictly React JS based, since this issue was regarding the deployment?

What kind of pull request is this.

Yes the PR's are to be in react only. Else it won't work on the website.

[Pranav-Rustagi]

@raj03kumar Being very polite, could you please checkout issue #452? Please try to reproduce it, I have mentioned the steps to reproduce it in the issue. Since you have reverted the merge, the issue is back. You can also try to check out the deployment preview from my pull request. You will find that issue does not appear there.

[raj03kumar]

@Pranav-Rustagi Alright, we apologize for the inconvenience which was caused due to lack of communication.

Always share something about your PR, else it looks like invalid.

If you are willing then you can recontribute into this issue Pranav.

[Pranav-Rustagi]

@raj03kumar Sure

[Pranav-Rustagi]

@raj03kumar @panwar8279 Could you please add labels to the PR.