Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: made search bar accessible on homepage 🔍✨ #931

Merged
merged 2 commits into from
Aug 3, 2023
Merged

feat: made search bar accessible on homepage 🔍✨ #931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
039fd4c
feat: made search bar accessible on homepage
0xabdulkhaliq Aug 3, 2023
406825c
feat: add screen reader only styles
0xabdulkhaliq Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/Homepage/Homepage/Homepage.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,3 +654,15 @@ input.search-input:hover {
margin-top:10px;
margin-bottom:20px;
}

.sr-only {
position: absolute !important;
width: 1px !important;
height: 1px !important;
padding: 0 !important;
margin: -1px !important;
overflow: hidden !important;
clip: rect(0, 0, 0, 0) !important;
white-space: nowrap !important;
border-width: 0 !important;
}
3 changes: 3 additions & 0 deletions src/Homepage/Homepage/Homepage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,10 @@ function Homepage() {
<h1> Game on!!</h1>
</div>
{/* The content in the cards came from mapping data1, if you want to contribute a game kindly add it to data1 in the Data folder first*/}
<label htmlFor="search-games" className="sr-only">Search for your favourite Game</label>
<input
id="search-game"
name="search-game"
type="text"
className="search-input"
value={searchQuery}
Expand Down
Loading