Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up transaction management for file_complete handler #930

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Clean up transaction management for file_complete handler #930

wants to merge 4 commits into from

Commits on Nov 25, 2024

  1. Clean up indexes on files and requests to make delete more efficient

    @BenGalewsky
    BenGalewsky committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    e175d73 View commit details
    Browse the repository at this point in the history

  2. Don't allow the user lookup in the auth decorator to leave a dangling… 

    … transaction

We are moving from implicit transactions to more fine-grain control. We don't
want to completely turn off implicit transactions during this migration, so any
database interaction can start the transaction which can spoil things later on.
This decorator was causing a transaction to be started for any user-facing REST endpoint.
Change this so it runs in its own transaction and commits it before entering the
endpoint code.
    @BenGalewsky
    BenGalewsky committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    fbaf5fa View commit details
    Browse the repository at this point in the history

  3. Fix last remaining reference to the archived property on requests

    @BenGalewsky
    BenGalewsky committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    f62720a View commit details
    Browse the repository at this point in the history

  4. Clean up transaction management for file_complete handler

    @BenGalewsky
    BenGalewsky committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    70a6702 View commit details
    Browse the repository at this point in the history