-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete Dataset From CLI #519
Conversation
35b5490
to
fa04926
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #519 +/- ##
==========================================
- Coverage 83.86% 83.05% -0.82%
==========================================
Files 27 27
Lines 1599 1670 +71
==========================================
+ Hits 1341 1387 +46
- Misses 258 283 +25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fa04926
to
9e2465a
Compare
This follows the examples used by the transform methods and allows us to use the _extract_message function to get better error messages. During development of this I learned that in unit tests that test for exceptions, any assertions inside the pytest.raises context manager will not be executed! Fixed numerous examples of that.
9e2465a
to
2e9ebb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the concerns
Problem
User's can't delete a dataset from the cache. They also can't see the details of a DID to debug
Approach
Add some new commands to the CLI
This gets back the details of Dataset ID 15...
You can delete a dataset with the new command
Do this and the server will refreash the dataset when you submit a new request.
Finally, there is a command line option to see deleted datasets (by default they are omited from the dataset report)
The ServiceX deployed on testing2 has been updated to have the endpoints needed for testing this