Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give users options to condense or eliminate progress bars #556

Merged
merged 5 commits into from
Jan 23, 2025

Conversation

ponyisi
Copy link
Collaborator

@ponyisi ponyisi commented Jan 21, 2025

  • Fix issues in ExpandableProgress that broke summary bar
  • Pass necessary arguments down from deliver()
  • Introduce enum class that lets user choose default display (all bars), compact display (only the total progress), or no progress bars at all

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.89%. Comparing base (a3c989a) to head (bde5c03).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #556      +/-   ##
==========================================
- Coverage   92.59%   91.89%   -0.70%     
==========================================
  Files          29       29              
  Lines        1823     1974     +151     
==========================================
+ Hits         1688     1814     +126     
- Misses        135      160      +25     
Flag Coverage Δ
unittests 91.89% <100.00%> (-0.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gordonwatts gordonwatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me - one suggestion and one question (because I didn't check out the code and test it in a notebook).

servicex/servicex_client.py Show resolved Hide resolved
servicex/expandable_progress.py Show resolved Hide resolved
@gordonwatts gordonwatts self-requested a review January 23, 2025 20:44
Copy link
Collaborator

@gordonwatts gordonwatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

@ponyisi
Copy link
Collaborator Author

ponyisi commented Jan 23, 2025

I will add user documentation in a new PR - this is actually somewhat involved but should be done properly.

@ponyisi ponyisi merged commit 933ddda into master Jan 23, 2025
36 of 37 checks passed
@ponyisi ponyisi deleted the compact-progress-bar branch January 23, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants