-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give users options to condense or eliminate progress bars #556
Conversation
ponyisi
commented
Jan 21, 2025
- Fix issues in ExpandableProgress that broke summary bar
- Pass necessary arguments down from deliver()
- Introduce enum class that lets user choose default display (all bars), compact display (only the total progress), or no progress bars at all
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #556 +/- ##
==========================================
- Coverage 92.59% 91.89% -0.70%
==========================================
Files 29 29
Lines 1823 1974 +151
==========================================
+ Hits 1688 1814 +126
- Misses 135 160 +25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me - one suggestion and one question (because I didn't check out the code and test it in a notebook).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic!
I will add user documentation in a new PR - this is actually somewhat involved but should be done properly. |