Rely on getpass for cache path expansion #679
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #679 +/- ##
=======================================
Coverage 98.17% 98.17%
=======================================
Files 29 29
Lines 2081 2082 +1
=======================================
+ Hits 2043 2044 +1
Misses 38 38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ponyisi
reviewed
Nov 2, 2025
| try: | ||
| username = getuser() | ||
| except Exception: # pragma: no cover - getpass failures are unexpected | ||
| username = "" |
There was a problem hiding this comment.
still, possibly dangerous depending on how the path is being specified (e.g. if this is a /${USER}/ specification the directory level will be one too high). Could the default be UnknownUser or something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
expand_cache_pathto clarify the return type and rely solely ongetpass.getuser()when expanding${USER}getpass.getuserand verify environment variables no longer override the cache directoryTesting
Fixes #612
https://chatgpt.com/codex/tasks/task_e_690617acf3108320a0c84e51616bff26