-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic flasher functionality #3
base: master
Are you sure you want to change the base?
Conversation
Creates a flasher pulse with illumination and pulse width with optional error
Thank you for this contribution. I have a few questions/suggestions:
|
Many thanks Jason for that quick review, good stuff
|
It wasn't necessary to close this PR - you can just add commits to the same branch.
Ah so its a fluctuation on the pulse width. Then it makes sense to be its own parameter
Alternatively you could call
No I mean you should add unittests that test the functionality that you add, to the pytest stuff. For demonstration of functionality, that should be kept seperate, and could be added as a jupyter notebook in the tutorials directory |
Yes that all looks good - the close was unintended - I added a comment and it did that |
The main methods in this flasher test harness are : Flash_100_200_pe_nsb_no_correction() - Plots fractional error (using a moving avg on charge) vs events with no pedestal subtraction Flash_100_200_pe_subtract_nsb_pedestal() - Same as above but subtracts avg of 20 NSB samples and plots for illuminations of 100 and 200 PE get_nsb_pedestal(), get_fractional_err_flashers(), PlotFractionalErr() - refactoring to separate out iteration and NSB rates / flasher params to a top level so we can drive it better without tweaking params embedded in code
Creates a flasher pulse with illumination and pulse width with optional error, I also
attach some plots I generated, where do you want the multiple flash test harness code to go?