Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive SST-Info #1009

Closed
wants to merge 21 commits into from
Closed

Interactive SST-Info #1009

wants to merge 21 commits into from

Conversation

bliu1013
Copy link
Contributor

Add interactive mode for SST-Info, activated by flag -i / --interactive.

@github-actions github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) AT: CLANG-FORMAT FAIL labels Oct 19, 2023
@github-actions
Copy link

CLANG-FORMAT TEST - FAILED (on last commit):
Run > ./scripts/clang-format-test.sh using clang-format v12 to check formatting

@github-actions github-actions bot added AT: CMAKE-FORMAT PASS and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Oct 19, 2023
@github-actions
Copy link

CMAKE-FORMAT TEST - PASSED

@sst-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

@feldergast
Copy link
Contributor

For core PRs, we prefer that you do a rebase against the latest devel branch instead of using merges. Also, unless there is some reason to preserve all the commits, it's best practice to squash them all into a single commit. We can do this as part of merging the PR, but if you need to rebase already, it's easy to do the squash locally as well. Typically we use an interactive rebase (git rebase -i devel) to do both of these at the same time. I'll contact you on how best to do this.

@feldergast
Copy link
Contributor

Also, just noticed that you did a merge from sstsimulator:master, which could cause strange artifacts in devel if we merge this. I'm going to close this for now until we can investigate further.

@feldergast feldergast closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants