Fix compiler error when calling addDataNTimes #1026

stkaplan · 2024-01-05T14:42:03Z

I get a compiler error when trying to call addDataNTimes from anywhere:

In file included from /opt/sst/include/sst/core/baseComponent.h:23,
                 from /opt/sst/include/sst/core/component.h:15,
                 from ../../../../../src/sst/elements/memHierarchy/cacheController.h:26,
                 from ../../../../../src/sst/elements/memHierarchy/cacheController.cc:21:
/opt/sst/include/sst/core/statapi/statbase.h: In instantiation of 'void SST::Statistics::Statistic<T>::addDataNTimes(uint64_t, InArgs&& ...) [with InArgs = {int}; T = long unsigned int; uint64_t = long unsigned int]':
../../../../../src/sst/elements/memHierarchy/cacheController.cc:207:37:   required from here
/opt/sst/include/sst/core/statapi/statbase.h:392:32: error: 'addData_impl_Ntimes' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
  392 |             addData_impl_Ntimes(N, std::forward<InArgs>(args)...);
      |             ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/opt/sst/include/sst/core/statapi/statbase.h:392:32: note: declarations in dependent base 'SST::Statistics::StatisticCollector<long unsigned int, true>' are not found by unqualified lookup
/opt/sst/include/sst/core/statapi/statbase.h:392:32: note: use 'this->addData_impl_Ntimes' instead

I don't really understand the message (hooray C++) but this is the suggested fix, and it works.

github-actions · 2024-01-05T14:42:28Z

CMAKE-FORMAT TEST - FAILED (on last commit):
Run > ./scripts/cmake-format-test.sh using cmake-format to check formatting

github-actions · 2024-01-05T14:42:28Z

CLANG-FORMAT TEST - PASSED

sst-autotester · 2024-01-05T14:48:44Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

stkaplan · 2024-01-05T14:49:55Z

Not sure what's up with the cmake-format check. The log shows:

CRITICAL __main__.py:635: Desired config file does not exist: experimental/.cmake-format.yaml

Is this a bad configuration, or did I do something wrong? Running cmake-format-test.sh locally gives a ton of errors unrelated to my one-line change.

github-actions · 2024-01-05T14:52:31Z

CLANG-FORMAT TEST - PASSED

github-actions · 2024-01-05T14:52:32Z

CMAKE-FORMAT TEST - PASSED

stkaplan · 2024-01-05T14:54:31Z

Never mind, I was using an outdated devel branch. Fixed it.

gvoskuilen · 2024-01-08T19:49:07Z

@stkaplan Looks like we missed adding a using statement when we added that function. In the interest of code consistency, could you instead fix it by adding a line at 371 that mirrors the line at 370 but for addData_impl_Ntimes instead of addData_impl? i.e., using StatisticCollector<T>::addData_impl_Ntimes; Thanks!

github-actions · 2024-01-08T20:18:10Z

CLANG-FORMAT TEST - PASSED

github-actions · 2024-01-08T20:18:15Z

CMAKE-FORMAT TEST - PASSED

gvoskuilen

Thanks!

stkaplan · 2024-01-08T20:19:37Z

@stkaplan Looks like we missed adding a using statement when we added that function. In the interest of code consistency, could you instead fix it by adding a line at 371 that mirrors the line at 370 but for addData_impl_Ntimes instead of addData_impl? i.e., using StatisticCollector<T>::addData_impl_Ntimes; Thanks!

Ah, didn't see that's why it works for addData_impl but not addData_impl_Ntimes. Fixed it to add the using statement.

sst-autotester · 2024-01-08T21:39:22Z

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed.

sst-autotester · 2024-01-08T21:41:17Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Build Num: 1302
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Build Num: 1283
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Build Num: 1285
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

Build Num: 487
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core

Build Num: 404
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Build Num: 362
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

Build Num: 316
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-13.2-XC14-ARM_OMPI-4.1.4_PY3.10_sst-elements

Build Num: 642
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-13.2-XC14-ARM_OMPI-4.1.4_PY3.10_sst-macro_withsstcore

Build Num: 150
Status: STARTED

Using Repos:

Repo: CORE (stkaplan/sst-core)

Repo: SQE (sstsimulator/sst-sqe)

Repo: ELEMENTS (sstsimulator/sst-elements)

Repo: MACRO (sstsimulator/sst-macro)

Pull Request Author: stkaplan

sst-autotester · 2024-01-08T22:42:23Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED

Note: Testing will normally be attempted again in approx. 4 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run.

Pull Request Auto Testing has FAILED (click to expand)

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Result: FAILED
Build #: 1302
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements/1302/consoleFull
Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Result: FAILED
Build #: 1283
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2/1283/consoleFull
Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Result: FAILED
Build #: 1285
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2/1285/consoleFull
Job: - Status: FAILURE

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

Result: PASSED
Build #: 487
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore/487/consoleFull

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core

Result: PASSED
Build #: 404
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core/404/consoleFull

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Result: PASSED
Build #: 362
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist/362/consoleFull

Job: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

Result: PASSED
Build #: 316
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core/316/consoleFull

Job: SST__AutotestGen2_NewFW_OSX-13.2-XC14-ARM_OMPI-4.1.4_PY3.10_sst-elements

Result: PASSED
Build #: 642
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_OSX-13.2-XC14-ARM_OMPI-4.1.4_PY3.10_sst-elements/642/consoleFull

Job: SST__AutotestGen2_NewFW_OSX-13.2-XC14-ARM_OMPI-4.1.4_PY3.10_sst-macro_withsstcore

Result: PASSED
Build #: 150
URL: Jenkins server at https://sst-jenkins.sandia.gov/view/SST/job/SST__AutotestGen2_NewFW_OSX-13.2-XC14-ARM_OMPI-4.1.4_PY3.10_sst-macro_withsstcore/150/consoleFull

gvoskuilen · 2024-01-08T22:55:17Z

@stkaplan The failures are a transient machine issue not caused by this PR. We'll rerun.

sst-autotester · 2024-01-09T03:10:04Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Build Num: 1304
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Build Num: 1285
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Build Num: 1287
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

Build Num: 488
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core

Build Num: 405
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Build Num: 363
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

Build Num: 317
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-13.2-XC14-ARM_OMPI-4.1.4_PY3.10_sst-elements

Build Num: 644
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-13.2-XC14-ARM_OMPI-4.1.4_PY3.10_sst-macro_withsstcore

Build Num: 151
Status: STARTED

Using Repos:

Repo: CORE (stkaplan/sst-core)

Repo: SQE (sstsimulator/sst-sqe)

Repo: ELEMENTS (sstsimulator/sst-elements)

Repo: MACRO (sstsimulator/sst-macro)

Pull Request Author: stkaplan

sst-autotester · 2024-01-09T04:24:44Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Build Num: 1304
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Build Num: 1285
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Build Num: 1287
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

Build Num: 488
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core

Build Num: 405
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Build Num: 363
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

Build Num: 317
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-13.2-XC14-ARM_OMPI-4.1.4_PY3.10_sst-elements

Build Num: 644
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-13.2-XC14-ARM_OMPI-4.1.4_PY3.10_sst-macro_withsstcore

Build Num: 151
Status: PASSED

sst-autotester · 2024-01-09T04:25:02Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ gvoskuilen ]!

sst-autotester · 2024-01-09T04:25:09Z

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Forked Repos cannot Automerge

sst-autotester · 2024-01-09T08:44:38Z

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Forked Repos cannot Automerge

sst-autotester · 2024-01-09T13:43:22Z

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Forked Repos cannot Automerge

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) AT: CLANG-FORMAT PASS AT: CMAKE-FORMAT FAIL and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Jan 5, 2024

stkaplan force-pushed the add-data-n-times branch from cc76749 to 700e837 Compare January 5, 2024 14:52

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) AT: CMAKE-FORMAT PASS and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Jan 5, 2024

github-actions bot removed the AT: CMAKE-FORMAT FAIL label Jan 5, 2024

Fix compiler error when calling addDataNTimes

822e0bb

stkaplan force-pushed the add-data-n-times branch from 700e837 to 822e0bb Compare January 8, 2024 20:17

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Jan 8, 2024

gvoskuilen approved these changes Jan 8, 2024

View reviewed changes

gvoskuilen added the AT: PRE-TEST INSPECTED label Jan 8, 2024

sst-autotester removed the AT: PRE-TEST INSPECTED label Jan 8, 2024

feldergast merged commit eea5b83 into sstsimulator:devel Jan 9, 2024
5 checks passed

Fix compiler error when calling addDataNTimes #1026

Fix compiler error when calling addDataNTimes #1026

Conversation

stkaplan commented Jan 5, 2024

github-actions bot commented Jan 5, 2024

github-actions bot commented Jan 5, 2024

sst-autotester commented Jan 5, 2024

stkaplan commented Jan 5, 2024

github-actions bot commented Jan 5, 2024

github-actions bot commented Jan 5, 2024

stkaplan commented Jan 5, 2024

gvoskuilen commented Jan 8, 2024

github-actions bot commented Jan 8, 2024

github-actions bot commented Jan 8, 2024

gvoskuilen left a comment

Choose a reason for hiding this comment

stkaplan commented Jan 8, 2024

sst-autotester commented Jan 8, 2024

sst-autotester commented Jan 8, 2024

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-13.2-XC14-ARM_OMPI-4.1.4_PY3.10_sst-elements

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-13.2-XC14-ARM_OMPI-4.1.4_PY3.10_sst-macro_withsstcore

Using Repos:

sst-autotester commented Jan 8, 2024

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core

Job: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Job: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

Job: SST__AutotestGen2_NewFW_OSX-13.2-XC14-ARM_OMPI-4.1.4_PY3.10_sst-elements

Job: SST__AutotestGen2_NewFW_OSX-13.2-XC14-ARM_OMPI-4.1.4_PY3.10_sst-macro_withsstcore

gvoskuilen commented Jan 8, 2024

sst-autotester commented Jan 9, 2024

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-13.2-XC14-ARM_OMPI-4.1.4_PY3.10_sst-elements

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-13.2-XC14-ARM_OMPI-4.1.4_PY3.10_sst-macro_withsstcore

Using Repos:

sst-autotester commented Jan 9, 2024

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core