Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#32 sst-info needs to be better at finding things #915

Closed
wants to merge 2 commits into from

Conversation

bpswenson
Copy link
Contributor

RE: #32 Updated sst-info to provide more assistance when unable to find library.

@github-actions github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) AT: CLANG-FORMAT FAIL labels Feb 13, 2023
@github-actions
Copy link

CLANG-FORMAT TEST - FAILED (on last commit):
Run > ./scripts/clang-format-test.sh using clang-format v12 to check formatting

@gvoskuilen
Copy link
Contributor

@bpswenson This has failed the clang-format check. Can you run the formatting script (./scripts/clang-format-test.sh) with clang-format v12 and update the branch? Once it passes that check, we can shepherd this through quickly. Thanks!

@bpswenson
Copy link
Contributor Author

sorry I keep meaning to do this. brew has clang-format@11 and clang-format@8 and clang-format@15 but that script seems to only allow 12 so I need to get that.

@feldergast
Copy link
Contributor

@bpswenson I’m working on fixing the library search paths in sst-info so they match what SST is doing. I can just add these changes to that PR if you’d like since I’ll already be editing that file. That PR will likely go in next Monday.

@feldergast
Copy link
Contributor

These changes were included in #1033. Closing.

@feldergast feldergast closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT: CLANG-FORMAT FAIL AT: WIP Mark PR as a Work in Progress (No Autotesting Performed)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants