Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for cmake-format GitHub Action #964

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Fixes for cmake-format GitHub Action #964

merged 2 commits into from
Jul 12, 2023

Conversation

berquist
Copy link
Member

For #716, a follow-up to #963. Apparently we are using an older form of the GitHub script language and I blindly updated the version for the CMake format checker. The path also wasn't updated to the experimental location.

There is a non-syntax update that needs to be made, which is that the action only runs cmake-format --check, not the additional and different cmake-lint, but shouldn't be solved in this PR.

@github-actions github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) AT: CLANG-FORMAT PASS and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Jul 10, 2023
@github-actions
Copy link

CLANG-FORMAT TEST - PASSED

@berquist
Copy link
Member Author

It's failing because the action run in the PR is not using the branch's updated PR_clang-format_test.yml, rather the broken one that was merged to devel.

@sst-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@sst-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

  • Build Num: 1079
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

  • Build Num: 1063
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

  • Build Num: 1065
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

  • Build Num: 436
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core

  • Build Num: 358
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

  • Build Num: 316
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

  • Build Num: 270
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-13.2-XC14-ARM_OMPI-4.1.4_PY3.10_sst-elements

  • Build Num: 421
  • Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-13.2-XC14-ARM_OMPI-4.1.4_PY3.10_sst-macro_withsstcore

  • Build Num: 103
  • Status: STARTED

Using Repos:

Repo: CORE (berquist/sst-core)
  • Branch: 716-cmake-format-gha
  • SHA: 13e2b0e
  • Mode: TEST_REPO
Repo: SQE (sstsimulator/sst-sqe)
  • Branch: devel
  • SHA: c9a61a7948c282a6c20a13feb3f6cee95f8805da
  • Mode: SUPPORT_REPO
Repo: ELEMENTS (sstsimulator/sst-elements)
  • Branch: devel
  • SHA: bb0270fc3e8e1a65dfb6f8c779488c22a284b0d0
  • Mode: SUPPORT_REPO
Repo: MACRO (sstsimulator/sst-macro)
  • Branch: devel
  • SHA: 432426e6e6a709368feb9abc6f91c654ffad9b6f
  • Mode: SUPPORT_REPO

Pull Request Author: berquist

@sst-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

  • Build Num: 1079
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

  • Build Num: 1063
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

  • Build Num: 1065
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

  • Build Num: 436
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core

  • Build Num: 358
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

  • Build Num: 316
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

  • Build Num: 270
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-13.2-XC14-ARM_OMPI-4.1.4_PY3.10_sst-elements

  • Build Num: 421
  • Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-13.2-XC14-ARM_OMPI-4.1.4_PY3.10_sst-macro_withsstcore

  • Build Num: 103
  • Status: PASSED

@sst-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
WARNING: NO REVIEWERS HAVE BEEN REQUESTED FOR THIS PULL REQUEST!

@sst-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

3 similar comments
@sst-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@sst-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@sst-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

jpkenny
jpkenny approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@jpkenny jpkenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sst-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ jpkenny ]!

@sst-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Forked Repos cannot Automerge

2 similar comments
@sst-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Forked Repos cannot Automerge

@sst-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Forked Repos cannot Automerge

@jpkenny
Copy link
Contributor

jpkenny commented Jul 12, 2023

@berquist should we be concerned about the cmake-format test?

@sst-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Forked Repos cannot Automerge

1 similar comment
@sst-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Forked Repos cannot Automerge

@berquist berquist changed the title Fixes for clang-format GitHub Action Fixes for cmake-format GitHub Action Jul 12, 2023
@berquist
Copy link
Member Author

@jpkenny I'm sorry, I keep typing "clang" instead of "cmake". The goal of this PR is to fix the cmake-format check in GitHub. Running cmake-format --check and cmake-lint with scripts/cmake-format-test.sh is clean, the problem is I made some silly mistakes in the GitHub Action that runs them, and I think because of rules for running the workflow

on:
  workflow_dispatch:
  pull_request_target:
    branches-ignore:
    - master
# Push option may be used in the future for developers forks
#  push:
#    branches-ignore:
#      - master

# NOTE: This script is run using pull_request_target.  It is critical that
#       that any changes to this script be looked at very carefully.
#       !! DO NOT COMPILE OR RUN ANY CODE FROM THE PR SOURCE REPO !!
#       Any changes to this script will not be run until it is merged into
#       the main repo.

we don't see fixes for this file until they're actually merged.

@jpkenny
Copy link
Contributor

jpkenny commented Jul 12, 2023

@jpkenny I'm sorry, I keep typing "clang" instead of "cmake". The goal of this PR is to fix the cmake-format check in GitHub. Running cmake-format --check and cmake-lint with scripts/cmake-format-test.sh is clean, the problem is I made some silly mistakes in the GitHub Action that runs them, and I think because of rules for running the workflow

on:
  workflow_dispatch:
  pull_request_target:
    branches-ignore:
    - master
# Push option may be used in the future for developers forks
#  push:
#    branches-ignore:
#      - master

# NOTE: This script is run using pull_request_target.  It is critical that
#       that any changes to this script be looked at very carefully.
#       !! DO NOT COMPILE OR RUN ANY CODE FROM THE PR SOURCE REPO !!
#       Any changes to this script will not be run until it is merged into
#       the main repo.

we don't see fixes for this file until they're actually merged.

Ok, thanks, I'll merge it.

@jpkenny jpkenny merged commit 74a67f7 into sstsimulator:devel Jul 12, 2023
1 of 2 checks passed
@berquist berquist mentioned this pull request Jul 12, 2023
Closed
@berquist berquist deleted the 716-cmake-format-gha branch July 12, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkenny jpkenny jpkenny approved these changes

Assignees
No one assigned
Labels
AT: CLANG-FORMAT PASS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@berquist @sst-autotester @jpkenny