SST Master Branch Merger: Auto Create Pull Request to Promote from devel to master - All Tests Ran Clean #2415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For my simulation, approximately 15-20% of CPU time is spent resolving one dynamic_cast in miranda. This dynamic cast does not appear to be necessary because mirandaCPU dispatches GeneratorRequests based on the request's operation. This patch replaces the dynamic_cast with an operation check and adds an assertion on the MemoryOpRequest's operation type. The assertion ensures a MemoryOpRequest is either READ or WRITE to avoid potential incorrect static_cast'ing into CustomOpRequests.
…nda-dyncast Automatically Merged using SST Pull Request AutoTester PR Title: b'miranda: check request operation instead of using dynamic_cast' PR Author: heyitsanthony
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request created to promote from devel branch to master due to successfully passing the following Jenkins Jobs :
JENKINS_SRN/SST__Nightly_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_Mainline : Build 358
JENKINS_SRN/SST__Nightly_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_Mainline_MR-2 : Build 182
JENKINS_SRN/SST__Nightly_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_Mainline_MT-2 : Build 179
JENKINS_SRN/SST__Nightly_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_Mainline_OutOfSource : Build 181
JENKINS_SRN/SST__Nightly_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_SST-Macro_NoCore : Build 180
JENKINS_SRN/SST__Nightly_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_SST-Macro_WithCore : Build 180
JENKINS_SRN/SST__Nightly_NewFW_sst-test_Clang-Format_sst-core : Build 1165
JENKINS_SRN/SST__Nightly_NewFW_sst-test_OMPI-4.1.4_PY3.6_Mainline : Build 1336
JENKINS_SRN/SST__Nightly_NewFW_sst-test_OMPI-4.1.4_PY3.6_Mainline_memH-A_Sweep-1 : Build 1312
JENKINS_SRN/SST__Nightly_NewFW_sst-test_OMPI-4.1.4_PY3.6_Mainline_memH-A_Sweep-2 : Build 1316
JENKINS_SRN/SST__Nightly_NewFW_sst-test_OMPI-4.1.4_PY3.6_Mainline_memH-A_Sweep-3 : Build 1313
JENKINS_SRN/SST__Nightly_NewFW_sst-test_OMPI-4.1.4_PY3.6_Mainline_memH-A_Sweep-4 : Build 1313
JENKINS_SRN/SST__Nightly_NewFW_sst-test_OMPI-4.1.4_PY3.6_Mainline_MR-2 : Build 1307
JENKINS_SRN/SST__Nightly_NewFW_sst-test_OMPI-4.1.4_PY3.6_Mainline_MT-2 : Build 1306
JENKINS_SRN/SST__Nightly_NewFW_sst-test_OMPI-4.1.4_PY3.6_Mainline_MT-4 : Build 1304
JENKINS_SRN/SST__Nightly_NewFW_sst-test_OMPI-4.1.4_PY3.6_Mainline_OutOfSource : Build 1305
JENKINS_SRN/SST__Nightly_NewFW_sst-test_OMPI-4.1.4_PY3.6_Make-Dist : Build 1310
JENKINS_SRN/SST__Nightly_NewFW_sst-test_OMPI-4.1.4_PY3.6_SST-Macro_NoCore : Build 1311
JENKINS_SRN/SST__Nightly_NewFW_sst-test_OMPI-4.1.4_PY3.6_SST-Macro_WithCore : Build 1311
JENKINS_SRN/SST__Nightly_NewFW_sst-test_OMPI-4.1.4_PY3.6_SST_Macro_Make-Dist : Build 1314
JENKINS_SRN/SST__Nightly_NewFW_sst-test_OMPI-NONE_PY3.6_Mainline : Build 1292
JENKINS_SRN/SST__Nightly_NewFW_sst-test_OMPI-NONE_PY3.6_Mainline_MT-2 : Build 1310
JENKINS_SRN/SST__Nightly_NewFW_Ubuntu-22.04_Doxygen : Build 188
JENKINS_SRN/SST__Nightly_NewFW_Ubuntu-24.04_OMPI-4.1.6_PY3.12_Mainline : Build 246
JENKINS_SRN/SST__Nightly_NewFW_Ubuntu-24.04_OMPI-4.1.6_PY3.12_Mainline_MR-2 : Build 181
JENKINS_SRN/SST__Nightly_NewFW_Ubuntu-24.04_OMPI-4.1.6_PY3.12_Mainline_MT-2 : Build 181
JENKINS_SRN/SST__Nightly_NewFW_Ubuntu-24.04_OMPI-4.1.6_PY3.12_Make-Dist : Build 183
JENKINS_SRN/SST__Nightly_NewFW_Ubuntu-24.04_OMPI-4.1.6_PY3.12_SST-Macro_NoCore : Build 183
JENKINS_SRN/SST__Nightly_NewFW_Ubuntu-24.04_OMPI-4.1.6_PY3.12_SST-Macro_WithCore : Build 180