Git tags, ABI based on version, deployment manager IO1-2235 + IO1-2727 #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c9141d2.
* cluster.disabled -> cluster.active * optimize flow when checking cluster.active
…into contract-v3
* fix transfer when liquidating
…into contract-v3
* cluster.disabled -> cluster.active * liquidate cluster with negative balance
* Remove check for liquidation in deposit * Fix cluster balance on reactivation
andrewbaronick
approved these changes
Mar 14, 2023
|
I just want to add that i did review but i am not very strong in bash to really review this well |
* reduceOperatorFee function
* add getValidator function * change getClusterBurnRate to getBurnRate * todo to change var to public --------- Co-authored-by: Lior Rutenberg <[email protected]>
* add Operator.whitelisted * update Views contract, gas usage update * test passed * operatorsWhitelist mapping * emit whitelisted address on registration * remove unused flag * add registerPrivateOperator * registerOperator -> setOperatorWhitelist for private operators * use only setOperatorWhitelist for setting / removing whithelist address
* use minimumLiquidationCollateral * add MINIMAL_LIQUIDATION_COLLATERAL * update min liquidation defualt value to 2 * allow owner to set any min collateral * update gas usage * remove MINIMAL_COLLATERAL constant --------- Co-authored-by: Lior Rutenberg <[email protected]>
hardhat tasks support quash 74bdd53 test
andrew-blox
requested changes
Mar 20, 2023
There was a problem hiding this comment.
I see a lot of changes were done to scripts and adding of tasks but i dont see any changes to read me. Are any changes needed there @mtabasco
| process.env.DECLARE_OPERATOR_FEE_PERIOD, | ||
| process.env.EXECUTE_OPERATOR_FEE_PERIOD, | ||
| process.env.MINIMUM_BLOCKS_BEFORE_LIQUIDATION, | ||
| process.env.MINIMUM_LIQUIDATION_COLLATERAL |
There was a problem hiding this comment.
need to update in .env.example as well right?
andrew-blox
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploy manager script for deploying / upgrading contracts in stage / testnet / main environments
When the target environment is stage, testnet or mainnet, an annotated semantic version tag for current branch is created and the ABI is published to this location in
contract-abibranch:docs/<env>/abi/<tag>when usingstage,testnetormain'docs//abi/dev' when using
developOn demand semantic versioning. By default, these rules are followed:
Tags created using
stageenv are treated as RCs (i.e v0.1.0-rc.0 -> v0.1.0-rc.1 ...)Tags created using
testnetormainenvs are treated as releases (i.e v0.1.0-rc.1 becomes v0.1.0)In both cases, if a version-type parameter is passed, the rule is overriden (i.e v0.1.0-rc.2 -> -t minor -> v0.2.0-rc.0)
Tags created using
developenv are not taggedDeployment scripts were replaced by hardhat tasks for better integration