Fix network withdrawals #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-blox
requested changes
Sep 19, 2023
test/dao/network-fee-withdraw.ts
Outdated
Comment on lines
73
to
80
| const amount = await ssvViews.getNetworkEarnings() / 2; | ||
|
|
||
| await ssvNetworkContract.withdrawNetworkEarnings(amount); | ||
| await ssvNetworkContract.withdrawNetworkEarnings(amount); | ||
|
|
||
| await expect(ssvNetworkContract.withdrawNetworkEarnings(amount | ||
| )).to.be.revertedWithCustomError(ssvNetworkContract, 'InsufficientBalance'); | ||
| }); |
There was a problem hiding this comment.
Please for these tests and all other tests where we do any withdraw lets add get assertions.
so in this particular test we do 3 withdrawls and one of them fails
After each one please do a getNetworkBalance and assert the number is correct.
So in this case:
First witdraw should be amount
Second should be 0
Third should be 2 blocks worth of network fees as the getNetworkBalance before the revert + revert took 2 blocks
Same for operator withdraw we should do a getOperatorEarnings and assert the number that its correct.
andrew-blox
reviewed
Sep 19, 2023
| const amount = await ssvViews.getNetworkEarnings() / 2; | ||
|
|
||
| await ssvNetworkContract.withdrawNetworkEarnings(amount); | ||
| expect(await ssvViews.getNetworkEarnings()).to.be.equals(((networkFee * 13) + (networkFee * 11) - amount)); |
There was a problem hiding this comment.
I like the way you assert much more then the way i suggested :)
andrew-blox
approved these changes
Sep 19, 2023
liorrutenberg
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Remove registerAuth implementation (#257) * remove registerAuth implementation * remove test * remove all references to registerAuth in tests * remove pending registerAuth * deploy stage-dev 30082023 * deploy stage v1.0.0.rc4 * add bug bounty details in README * Fix network withdrawals (#262) * fix sequential network withdrawals issue * A validator can voluntarily exit (#263) * A validator can voluntarily exit * Update local-dev.md (#260) * Update local-dev.md * Fix Types.shrink() (#265) * fix Types.shrink * v1.0.0.rc5 * goerli_dev deployment * Remove validator gas costs metrics (#266) * holesky dev (#267) * Get Network total validators count (#270) * add SSVViews.getNetworkValidatorsCount() * testnet holesky (#268) * change input modifiers * rename __gap (#269) * OperatorLib gas optimizations (#273) * remove named return params (#272) * add msg.sender to ValidatorExited event (#271) * remove storage checks * add audit reports --------- Co-authored-by: andrew-blox <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the DAO index when making a network withdrawal.