-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Review] Balance calculation when operators will be removed #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Mohsen-T
commented
Nov 27, 2023
- Reviewed all the code and test scripts related to the SSVOperators.remoteOperator() function
- Confidently affirm that there are no errors or logical inconsistencies in the code
- Could you please clarify the rationale for using the Operator's whitelisted variable independently, as opposed to utilizing the SSVStorage's StorageData structure's operatorsWhitelist mapping variable?
- Ticket: Review/fix balance calculations when removing operators
mtabasco
requested changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mohsen-T please create tests for:
with a cluster with 4 operators:
-
remove an operator, progress blocks and confirm:
- the cluster balance is reduced taking into account only 3 operators since the block where the operator was removed.
- try to register a new validator in the new cluster passing the same operator ids, including the removed one (I think we already have this test in place)
- try to
removeValidator
and check the operator removed is skipped for the updates. - same with
liquidate
, try with the same list of operator Ids and check the removed operator is not taken into account. - same with
reactivate
andwithdraw
-
SSVNetworkViews
- Check if there are cluster balance calculations performed on-the-fly and refactor to use cluster/operator libraries.
andrew-blox
reviewed
Nov 27, 2023
mtabasco
approved these changes
Nov 29, 2023
mtabasco
requested changes
Nov 29, 2023
mtabasco
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.