Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Review] Balance calculation when operators will be removed #284

Merged
merged 10 commits into from
Dec 11, 2023

Conversation

Mohsen-T
Copy link
Contributor

  • Reviewed all the code and test scripts related to the SSVOperators.remoteOperator() function
  • Confidently affirm that there are no errors or logical inconsistencies in the code
  • Could you please clarify the rationale for using the Operator's whitelisted variable independently, as opposed to utilizing the SSVStorage's StorageData structure's operatorsWhitelist mapping variable?
  • Ticket: Review/fix balance calculations when removing operators

Copy link
Collaborator

@mtabasco mtabasco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mohsen-T please create tests for:
with a cluster with 4 operators:

  • remove an operator, progress blocks and confirm:

    • the cluster balance is reduced taking into account only 3 operators since the block where the operator was removed.
    • try to register a new validator in the new cluster passing the same operator ids, including the removed one (I think we already have this test in place)
    • try to removeValidator and check the operator removed is skipped for the updates.
    • same with liquidate, try with the same list of operator Ids and check the removed operator is not taken into account.
    • same with reactivate and withdraw
  • SSVNetworkViews

    • Check if there are cluster balance calculations performed on-the-fly and refactor to use cluster/operator libraries.

contracts/SSVNetworkViews.sol Outdated Show resolved Hide resolved
contracts/modules/SSVViews.sol Outdated Show resolved Hide resolved
@Mohsen-T Mohsen-T requested a review from andrew-blox November 28, 2023 18:47
test/sanity/balances.ts Outdated Show resolved Hide resolved
@Mohsen-T Mohsen-T requested a review from mtabasco November 30, 2023 04:28
@mtabasco mtabasco changed the base branch from main to v1.1.0 December 5, 2023 11:03
@Mohsen-T Mohsen-T merged commit a886dc8 into v1.1.0 Dec 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants