Multi-whitelisted operators [audited] #299
Conversation
| if (!s.operators[operatorId].whitelisted) s.operators[operatorId].whitelisted = true; | ||
|
|
There was a problem hiding this comment.
im not sure this is the best flow, what if you want to add a bunch of whitelists then make yourself public
There was a problem hiding this comment.
@andrew-blox Done. This change requires the operator owner to call the setOperatorsPrivateUnchecked function to make the operator private. If not, anyone can register validators using it even having whitelisted addresses.
There was a problem hiding this comment.
@arielssv i know you already know just affirming it here
| s.operatorsWhitelist[operatorId] = address(whitelistingContract); | ||
| } | ||
|
|
||
| emit OperatorWhitelistingContractUpdated(operatorIds, address(whitelistingContract)); |
There was a problem hiding this comment.
is it worth to emit the old whitelist address as well?
There was a problem hiding this comment.
I think it is enough to emit the new one. Using off-chain tools, all previous addresses can be retrieved.
| } else { | ||
| operator.whitelisted = true; | ||
| } |
There was a problem hiding this comment.
Not sure i understand why this is in an else? seems like if there is not already an address there then we wont make whitelisted to true?
personally i dont think we should be changing whitelisted to true or false only if they request via the function that is made now (comment about this above)
There was a problem hiding this comment.
@andrew-blox Done. This change requires the operator owner to call the setOperatorsPrivateUnchecked function to make the operator private.
Also, the logic of whitelisted changed a bit. Thanks
contracts/modules/SSVViews.sol
Outdated
| function getWhitelistedOperators( | ||
| uint64[] calldata operatorIds, | ||
| address whitelistedAddress | ||
| ) external view override returns (uint64[] memory whitelistedOperatorIds) { |
There was a problem hiding this comment.
It would be nice if this function works with external contracts as well.
There was a problem hiding this comment.
Done: isAddressWhitelistedInWhitelistingContract
mtabasco
changed the title
mtabasco
changed the title
mtabasco
changed the title
The new feature allows operators to whitelist multiple EOAs/generic contracts and one external whitelisting contract.
EOAs/generic contracts
Whitelisting contracts
ISSVWhitelistingContractand comply with ERC165