Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs regarding bury sibling cards #763

Merged
merged 4 commits into from
Oct 18, 2023

Conversation

ronzulu
Copy link
Collaborator

@ronzulu ronzulu commented Oct 17, 2023

Hi @st3v3nmw

This fixes bugs:
#759
#760

I've included a new test case, and updated a few that were based on an incorrect understanding of the existing 1.10.1 functionality.

Apologies for the extra work!

Cheers
Ronny

@st3v3nmw st3v3nmw changed the title [Important] Fixes bugs regarding bury sibling (that I recently introduced) Fix bugs regarding bury sibling cards Oct 18, 2023
@st3v3nmw st3v3nmw merged commit 1947916 into st3v3nmw:master Oct 18, 2023
@st3v3nmw
Copy link
Owner

st3v3nmw commented Oct 18, 2023

Thanks for the fixes @ronzulu!

@ronzulu
Copy link
Collaborator Author

ronzulu commented Oct 19, 2023

Sorry Stephen, I just noticed a bug with this fix.

Not sure when you were intending to do a release, but please hold off.

Newdea pushed a commit to open-spaced-repetition/obsidian-spaced-repetition-recall that referenced this pull request Dec 1, 2023
* Implemented fixes, added test case

* Write question postponement list; update change log

* Post pnpm format

* Minor fix for unit test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants