Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double error reporting if multiple nodes reference the same comment #102

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Fix double error reporting if multiple nodes reference the same comment #102

wants to merge 5 commits into from

Conversation

EmilMassey
Copy link
Contributor

Fixes #101

@staabm
Copy link
Owner

staabm commented Jun 28, 2024

please add a test-case which shows we don't have the same problem for other todo-by rules

@EmilMassey EmilMassey marked this pull request as draft June 28, 2024 14:41
@EmilMassey
Copy link
Contributor Author

Unfortunately, all rules have the same problem. I thought this problem is only related to collector, but it is not. I'll need to find a more generic fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule errors are reported doubly when multiple nodes reference the same comment
2 participants
@EmilMassey @staabm