Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add figure from the MLM demo paper #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add figure from the MLM demo paper #33

wants to merge 1 commit into from

Conversation

rbavery
Copy link
Collaborator

@rbavery rbavery commented Oct 21, 2024

Description

This adds the figure from the demo paper to the README

Related Issue

Type of Change

  • 📚 Examples, docs, tutorials or dependencies update;
  • 🔧 Bug fix (non-breaking change which fixes an issue);
  • 🥂 Improvement (non-breaking change which improves an existing feature);
  • 🚀 New feature (non-breaking change which adds functionality);
  • 💥 Breaking change (fix or feature that would cause existing functionality to change);
  • 🔐 Security fix.

Checklist

  • I've read the CONTRIBUTING.md guide;
  • I've updated the code style using make check;
  • I've written tests for all new methods and classes that I created;
  • I've written the docstring in Google format for all the methods and classes that I used.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the image under docs/static.

@@ -51,6 +51,8 @@ The main objectives of the extension are:
2) record all necessary bands, parameters, modeling artifact locations, and high-level processing steps to deploy
an inference service.

<img src="./STAC_MLM.png" width="1000px" alt="STAC_MLM">
Copy link
Collaborator

@fmigneault fmigneault Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not enforce some width. It doesn't work nicely with other devices than your standard monitor. Simply use a markdown image reference and let it auto-scale.

Also, I think it makes more sense to place it just before the "See Best Practices..." below. Here, it cuts the summary description in two.

Consider adding the citation as well under it. Just another way to communicate the paper reference along #32.

Francis Charette-Migneault, Ryan Avery, Brian Pondi, Joses Omojola, Simone Vaccari, Parham Membari, Devis Peressutti, Jia Yu, and Jed Sundwall. 2024. Machine Learning Model Specification for Cataloging Spatio-Temporal Models (Demo Paper). In 3rd ACM SIGSPATIAL International Workshop on Searching and Mining Large Collections of Geospatial Data (GeoSearch’24), October 29–November 1 2024, Atlanta, GA, USA. ACM, New York, NY, USA, 4 pages. https://doi.org/10.1145/3681769.3698586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants