Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enum to status field #17

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Add enum to status field #17

merged 2 commits into from
Nov 25, 2024

Conversation

m-mohr
Copy link
Contributor

@m-mohr m-mohr commented Nov 25, 2024

Closes #16

The field descrption explicity says "One of the value listed here", so it seems it's meant to be an enum.

Copy link
Member

@emmanuelmathot emmanuelmathot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would tend to agree, but it is all about the semantics of the word chosen, so if we think all cases are covered, I am okay.

@m-mohr
Copy link
Contributor Author

m-mohr commented Nov 25, 2024

I can't think of anything else and we also didn't see any issues coming up in the last years, so I assume it's fine. And adding values to an enum is not that big of a deal either, I think.

@m-mohr m-mohr merged commit 315d187 into main Nov 25, 2024
2 checks passed
@m-mohr m-mohr deleted the m-mohr-patch-1 branch November 25, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify that status field is open
2 participants