feat: resolves #4 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there @m-mohr |
|
Hi @m-mohr, looking forward for your feedback on this one :-) |
m-mohr
reviewed
Jul 9, 2024
m-mohr
reviewed
Jul 9, 2024
emmanuelmathot
requested changes
Jul 9, 2024
There was a problem hiding this comment.
the new field is missing in the field table.
@@ -36,6 +36,7 @@ The fields in the table below can be used in these parts of STAC documents:
| product:type | string | The product type. |
| product:timeliness | string | The average expected timeliness of the product as an [ISO 8601 Duration](https://en.wikipedia.org/wiki/ISO_8601#Durations). |
| product:timeliness_category | string | A proprietary category identifier for the timeliness of the product. |
+| product:acquisition_type | string | The acquisition type of the product. |
> \[!IMPORTANT]
> `product:timeliness` is REQUIRED if `product:timeliness_category` is provided.
|
@emmanuelmathot looking forward for your review |
|
@m-mohr I addressed also all the MD warnings, build should be clean right now |
|
@m-mohr addressed also |
emmanuelmathot
approved these changes
Jul 16, 2024
|
@m-mohr at the state of the art, we got approvals from both @emmanuelmathot and @fabricebrito , PR can be now merged, many thanks in advance! |
|
Thanks @emmanuelmathot for merging, very appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per commit message, this modification introduces the product:acquisition_type property