Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for IAU codes. #12
Adds support for IAU codes. #12
Changes from 26 commits
eb2ad79
fea2e98
1366879
6f07dc2
e85a10d
b777fec
3989cf2
2e93bd8
47ffff0
508ff35
a9d021d
7952944
737b569
ba2bd56
8b9d07a
a7ddf4e
99a9ad8
9419cb8
2cdeee5
c565188
f084c50
af9e424
aa818fd
9cd8778
689427f
bd0b3f5
cc38619
ecba565
72dfbcc
9baa46a
478f9eb
b786819
7ded8eb
bbb32ab
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example uses IAU instead of IAU_2015 like other ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlaura It looks like the linter wants the table to be formatted more like this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, tests are passing now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think good to merge? 😰
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, would be good to have 1-2 more people to approve. Thus I tagged a couple of people above. Could also be others...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hate to ask, but if we're adding IAU, why aren't we also adding the Esri registry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to add! Link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know that anyone's really happy to add it 😄
Case against Esri registry:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One case for, maybe not a strong one, is that they are in the PROJ library and ship with things like QGIS (among a ton of others). So, if a STAC item declares say ESRI:53029, the client would know to use Sphere_Van_Griten_I just from the code.
I think though, that we discussed (?) codes being more informative and clients really wanting the WKT / proj.json so that might not be a strong rationale. (I have a vague recollection of a discussion on a PR perhaps?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The extension doesn't say which registries are allowed. There's nothing in the schema that prevents from using ESRI:xxxx codes. The table in the extension is more a heads-up for potential registries, whether we add or don't add ESRI doesn't make a huge difference here. So I'd say just add it to make people aware of the ESRI prefix and where to "look it up"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is a link to maybe include? https://spatialreference.org/ref/esri/
To Howard's point, I'm not sure of another link. I'll get this one added can change if someone has another link they's prefer.