PMTiles: Added field pmtiles:layer_properties
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-mohr
force-pushed
the
pmtiles-vector-property-schemas
branch
3 times, most recently
from
236d684
to
6d384b3
Compare
m-mohr
force-pushed
the
pmtiles-vector-property-schemas
branch
from
6d384b3
to
b16e103
Compare
bdon
reviewed
Oct 3, 2023
bdon
reviewed
Oct 5, 2023
bdon
reviewed
Oct 5, 2023
| | href | string | **REQUIRED**. Link to a PMTiles file (usually ends with `.pmtiles`). | | ||
| | type | string | Recommended to be set to `application/vnd.pmtiles`. | | ||
| | pmtiles:layers | \[string] | For vector tiles, the layers to show on the map by default. If not provided, it's up to the discretion of the implementation to choose a layer from the `vector_layers` in the PMTiles metadata. | | ||
| | pmtiles:layer_properties | Map\<string, Map\<string, JSON Schema Object>> | For vector tiles, the properties/fields available for each layer and their corresponding [JSON Schema](#json-schema-object) as an object. | |
There was a problem hiding this comment.
Is this meant to be exhaustive of all layer properties existing in the tileset (like in TileJSON), or only the properties/fields we want to visualize (like in the pmtiles:layers)?
There was a problem hiding this comment.
Good question. I guess the second...
There was a problem hiding this comment.
OK, that seems much more feasible than the former, though TileJSON vector_layers does not provide information about the possible enum values etc so the JSON Schema objects need to be constructed with outside knowledge.
There was a problem hiding this comment.
Yes, indeed. If we would have enough information in vector_layers, we would not need this construct at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @cholmes @bdon