Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProjectionExtension v2 (proj:epsg -> proj:code) #1287

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented Dec 4, 2023

Related Issue(s):

Description:

The intention of this PR is to still support using epsg and just store it in proj:code.

Note

This PR removes epsg as a positional argument to ProjectionExtension.apply. It also removes all positional arguments to it should raise nice errors for that scenario.

Another option would be to allow positional arguments and automatically deduce whether they should be interpreted as epsg or code based on type. I suspect that using epsg as a positional argument in apply is rare, so I strongly prefer the approach in this PR.

TO DO:

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@nick-j-roberts
Copy link

Just checking in on this, is there a date by which the change to support proj:code instead of proj:epsg is expected to take effect?

@gadomski
Copy link
Member

Just checking in on this, is there a date by which the change to support proj:code instead of proj:epsg is expected to take effect?

Not at this time ... always looking for folks to help out to help move things along!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for projection v2.0.0 extension
3 participants