ProjectionExtension v2 (proj:epsg -> proj:code) #1287
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
The intention of this PR is to still support using epsg and just store it in
proj:code
.Note
This PR removes epsg as a positional argument to ProjectionExtension.apply. It also removes all positional arguments to it should raise nice errors for that scenario.
Another option would be to allow positional arguments and automatically deduce whether they should be interpreted as
epsg
orcode
based on type. I suspect that usingepsg
as a positional argument inapply
is rare, so I strongly prefer the approach in this PR.TO DO:
PR Checklist:
pre-commit
hooks pass locallyscripts/test
)