update storage extension to v2.0.0 #1561
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1561 +/- ##
==========================================
+ Coverage 92.43% 92.57% +0.13%
==========================================
Files 55 55
Lines 8371 8456 +85
Branches 964 972 +8
==========================================
+ Hits 7738 7828 +90
+ Misses 449 445 -4
+ Partials 184 183 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gadomski
requested changes
Jul 29, 2025
| .. code-block:: python | ||
|
|
||
| >>> item: pystac.Item = ... | ||
| >>> storage_ext = StorageSchemesExtension.ext(item) |
There was a problem hiding this comment.
We usually only have on "entrypoint" per extension ... in this case, it would be StorageExtension. Storage schemes should be an attribute of that extension.
Comment on lines
+371
to
+376
| class StorageRefsExtension( | ||
| _StorageExtension, | ||
| Generic[U], | ||
| PropertiesExtension, | ||
| ExtensionManagementMixin[pystac.Item | pystac.Collection | pystac.Catalog], | ||
| ): |
There was a problem hiding this comment.
Similarly, I don't know if we need StorageRefsExtesion ... we probably just need a StorageRefs class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updates storage extension to v2.0.0. Due to the major changes in v2, I have not attempted to make migrations from v1 to v2
StorageScheme platform property allows templated uri's, so arbitrary additional properties are allowed to be set on StorageScheme objects
PR Checklist:
pre-commit run --all-files)pytest)