Skip to content

Update DefaultStacIO to fix parsing non-ascii in urls #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented Jun 26, 2025

Related Issue(s):

Description:

Since urllib3 handles non-ASCII characters in URLs and it is already an optional dependency the simplest fix seemed to be just to use that if available.

I still need to add a test.

PR Checklist:

  • Pre-commit hooks pass (run pre-commit run --all-files)
  • Tests pass (run pytest)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@jsignell jsignell marked this pull request as ready for review July 16, 2025 14:33
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.38%. Comparing base (795befa) to head (5b6e765).

Files with missing lines Patch % Lines
pystac/stac_io.py 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1566      +/-   ##
==========================================
- Coverage   92.43%   92.38%   -0.06%     
==========================================
  Files          55       55              
  Lines        8371     8374       +3     
  Branches      964      965       +1     
==========================================
- Hits         7738     7736       -2     
- Misses        449      453       +4     
- Partials      184      185       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jsignell jsignell requested a review from gadomski July 16, 2025 14:38
@jsignell jsignell changed the title Update DefaultStacIO to fix parsing ascii in urls Update DefaultStacIO to fix parsing non-ascii in urls Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STACError: HREF: <url> does not resolve to a STAC object
2 participants