Fix: Prevent duplicate root_path in pagination links

[fabito]

When a custom ROOT_PATH environment variable is used, the "next" pagination link could incorrectly include the root_path twice.

This was because the BaseLinks.url property, which generates the base for these links, did not properly account for the ROOT_PATH already being part of self.base_url (derived from get_base_url) when joining it with the request path.

The BaseLinks.url property in stac_fastapi/pgstac/models/links.py has been updated to ensure that the request path is made relative to the base_url's path component before joining. This prevents the duplication.

A new test case, test_pagination_link_with_root_path, has been added to tests/api/test_links.py to specifically verify that pagination links are generated correctly when ROOT_PATH is set.

PR Checklist:

• pre-commit hooks pass locally
• Tests pass (run make test)
• Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
• Changes are added to the CHANGELOG.

[vincentsarago]

🤔 one more PR/issue about root-path 😭

we extensively worked on this recently #221 which seemed to fix most issues 😭

From experience, issues are usually do to miss configuration on the proxy side

[vincentsarago]

as much as I would like to fix all the issues in stac-fastapi, I'm still lacking replicable example of this.

we do have k8s/aws lambda/azure deployments set up and the root-path duplication is usually found for mis configuration.

can you tell a bit more about your environment?

[fabito]

stac-fastapi-pgstac=5.0.2
AWS Lambda runtime
python 3.11

  environment = {
    name         = "My STAC API"
    version      = var.api_version
    cors_origins = "*"
    cachecontrol = "public, max-age=3600"
    debug        = "true"

    POSTGRES_USER        = local.database_username
    POSTGRES_PASS        = local.database_passwprd
    POSTGRES_DBNAME      = local.database_name
    POSTGRES_HOST_READER = local.database_hostname
    POSTGRES_HOST_WRITER = local.database_hostname
    POSTGRES_PORT        = local.database_port
    ROOT_PATH            = "/${local.stac_api_root_path}"
  }

I am not using the existing StacApi instance from stac_fastapi.pgstac.app I am using a custom one that uses a custom PostgresSettings that fetches db password from secret manager.

I will try stac_fastapi.pgstac.app.app, maybe there is something wrong in how I'm creating and configuring the StacApi.

[fabito]

I just tried with the existing Mangum handler: stac_fastapi.pgstac.app.handler, same problem, unfortunately: next link (in the search response) broken with duplicated root_path.

[vincentsarago]

I've created https://github.com/developmentseed/stac-fastapi-root-path-lambda to try to replicate and I can't get the duplicate paths

[fabito]

I think I was able to reproduce the error in these tests:

• Reproduce duplicated root-path issue in unit test #265

Let me know if the test fixtures make sense.