Improve RFC 3339 datetime handling #368
Conversation
philvarner
changed the title
| @@ -171,18 +159,22 @@ def validate_datetime(cls, v): | |||
|
|
|||
| dates = [] | |||
| for value in values: | |||
| if value == "..": | |||
| dates.append(value) | |||
| if value == ".." or value == "": | |||
There was a problem hiding this comment.
this should probably be replace with parse_interval also
| from typing import TypedDict | ||
|
|
||
| import attr | ||
| import geoalchemy2 as ga | ||
| from stac_pydantic.shared import DATETIME_RFC339 |
There was a problem hiding this comment.
DATETIME_RFC339 has been deprecated in stac_pydantic. It has several problems including, not parsing fractional seconds or timezones other than Z.
philvarner
force-pushed
the
pv/datetime-parsing
branch
from
69014d6
to
c9b83de
Compare
| RUN python -m pip install --upgrade pip | ||
| RUN python -m pip install mkdocs mkdocs-material pdocs | ||
|
|
||
| COPY . /opt/src | ||
|
|
||
| WORKDIR /opt/src | ||
|
|
||
| RUN python -m pip install -e \ | ||
| RUN python -m pip install \ |
There was a problem hiding this comment.
-e isn't needed in this case, and it only affects the first package name after it (rather than all of them)
| @@ -10,6 +10,8 @@ | |||
| "attrs", | |||
| "pydantic[dotenv]", | |||
| "stac_pydantic==2.0.*", | |||
| "pystac==1.*", | |||
There was a problem hiding this comment.
it took me 2 hours to figure out that the docs broke because I'd added an import from pystac, but it's not a dependency of this package. The tests worked because everything gets installed when they run.
philvarner
changed the title
|
Looks like a black update broke a whole bunch of builds out there: psf/black#2964 |
Related Issue(s):
Description:
PR Checklist:
pre-commit run --all-files)make test)make docs)