Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nginx service as second docker-compose stack #503

Merged
merged 5 commits into from
Feb 27, 2023

Conversation

geospatial-jeff
Copy link
Collaborator

@geospatial-jeff geospatial-jeff commented Nov 28, 2022

Related Issue(s):

Description:
Adds a NGINX container to the docker-compose stack to help debug issues with root paths and link resolution when running the application behind a proxy; and to serve as a minimal reference example for how proxies should be configured. The NGINX server runs on port 80 and proxies both backends behind the /api/v1/pgstac and /api/v1/sqlalchemy endpoints, root paths are set accordingly in each application. I added the UVICORN_ROOT_PATH environment variable to expose uvicorn's root path argument without rewriting docker commands.

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
@gadomski gadomski added this to the 2.4.4 milestone Jan 18, 2023
@gadomski gadomski self-assigned this Jan 18, 2023
@gadomski gadomski changed the title add nginx service to docker-compose, proxy pgstac and sqlalchemy apps Add nginx service as second docker-compose stack Jan 18, 2023
@gadomski gadomski requested review from gadomski and removed request for gadomski February 15, 2023 15:27
geospatial-jeff and others added 3 commits February 27, 2023 14:53
Co-authored-by: Christian Wygoda <[email protected]>
Includes a Makefile rule to run it, and some documentation in README.md. Also
adds a markdownlint silencer and one or two touchups to the whitespace.
Copy link
Collaborator

@moradology moradology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 - Tested new compose stack, rebased out conflicts, and updated changelog to reflect this feature

@gadomski gadomski enabled auto-merge (squash) February 27, 2023 22:07
@gadomski gadomski merged commit 1de7b8b into master Feb 27, 2023
@gadomski gadomski deleted the add-nginx-container branch February 27, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants