add request and jsonschema optional dependencies #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
commented
Jul 8, 2024
vincentsarago
commented
Jul 8, 2024
| # can't use `stac_obj.model_dump()` here | ||
| # b/c jsonschema expects pure string representations, not python types | ||
| stac_dict = json.loads(stac_obj.model_dump_json()) | ||
| stac_dict = stac_obj.model_dump(mode="json") |
There was a problem hiding this comment.
use mode="json" instead of model_dump_json + json.loads
vincentsarago
commented
Jul 8, 2024
| stac_item = r.json() | ||
| try: | ||
| item = Item(**stac_item) | ||
| item = Item.model_validate(stac_item) |
There was a problem hiding this comment.
model_validate is the recommended way of parsing/validating an object
gadomski
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
requestsandjsonschemaare imported for validation but are not part of the dependencies. This PR adds avalidationoptional dependencies.