Check if datetime is a str instance before parsing #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can anyone take a look into this? |
|
Not sure if this is superseded by #75. @geospatial-jeff might have a better idea |
|
Thanks @kylebarron you are correct, as of #75 the field is simply typed as datetime instead of a union. When passed a string, pydantic will validate the date string against ISO format and convert to a datetime object. I think this PR can be closed. |
|
Apologies I'm trying to figure out GitHub mobile and it's not going so well haha. I just realized that the ItemProperties.datetime member is still typed with a Union, once that is fixed I think we will have the behavior described in this PR. |
Closed
|
Closing as superseded by #75 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse to rfc3339 only if the dates are strings.