-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
123: Support process
arrays
#166
123: Support process
arrays
#166
Conversation
- emit deprecation warning if payload process definition is a bare dictionary - expect payload process definition to be first element in a list
- update existing tests fixture to use a list of process definitions - add a test to check for deprecation warning when using a dict for process definition
7a9342e
to
b51ac48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is all good, there's just some minor subtleties in the error message language that I think need to be worked out to avoid communicating inaccurate messaging to users.
Note that all of this special casing and trying to work out what the error is if we just adopted something like pydantic to parse the incoming payloads into types: if that fails then pydantic can provide much better error messages with regard to the problem.
Oh look, we already have a head start on this for someday in the future: https://github.com/Element84/swoop/blob/main/src/swoop/api/models/workflows.py#L206. 😁
Nice. Yeah, this is something I'm interested in getting in here at some point. |
b51ac48
to
698d444
Compare
Related Issue(s):
process
arrays #123Proposed Changes:
PR Checklist: