Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add patch_url kwarg for signing hrefs and objects #31

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add patch_url kwarg for signing hrefs and objects #31

wants to merge 3 commits into from

Conversation

jsignell
Copy link
Member

This seems like potentially a better approach than just signing everything but it would be great to get a second opinion

closes #29

@jsignell
Copy link
Member Author

@gadomski do you have an opinion on this?

gadomski
gadomski reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, running everything through planetary_computer.sign doesn't really scale in the long run (do we add every big provider's signing package to the chain?) so I'm 👍🏼.

xpystac/core.py Outdated Show resolved Hide resolved
@jsignell jsignell changed the title Add pass_urls kwarg for assets Add patch_urls kwarg for assets Nov 13, 2023
@jsignell jsignell changed the title Add patch_urls kwarg for assets Add patch_url kwarg for Nov 13, 2023
@jsignell jsignell changed the title Add patch_url kwarg for Add patch_url kwarg for signing hrefs and objects Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadomski gadomski gadomski left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Planetary computer url signing
2 participants
@jsignell @gadomski