Disallow unused expressions

stack-auth · Jul 14, 2024 · eaa0930 · eaa0930
1 parent 580bd73
commit eaa0930
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/eslint-configs/defaults.js b/eslint-configs/defaults.js
@@ -8,6 +8,7 @@ module.exports = {
     tsconfigRootDir: process.cwd(),
   },
   rules: {
+    "no-unused-expressions": ["error", { enforceForJSX: true }],
     "no-trailing-spaces": "warn",
     "key-spacing": "error",
     "indent": ["error", 2, {

diff --git a/packages/stack-shared/src/utils/promises.tsx b/packages/stack-shared/src/utils/promises.tsx
@@ -236,7 +236,11 @@ export function rateLimited<T>(
     );
 
     for (const nextFunc of nextFuncs) {
-      value.status === "ok" ? nextFunc[0](value.data) : nextFunc[1](value.error);
+      if (value.status === "ok") {
+        nextFunc[0](value.data);
+      } else {
+        nextFunc[1](value.error);
+      }
     }
   };