Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add callbackUrl to all functions that require a callback URL #366

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Add callbackUrl to all functions that require a callback URL #366

merged 3 commits into from
Dec 12, 2024

Conversation

fomalhautb
Copy link
Contributor

@fomalhautb fomalhautb commented Dec 11, 2024 •
edited by ellipsis-dev bot
Loading

Fixes #364

Important

Add callbackUrl requirement to email functions in _StackClientAppImpl and _StackServerAppImpl when window is undefined.

  • Behavior:
    • Updated sendVerificationEmail, sendForgotPasswordEmail, and sendMagicLinkEmail in _StackClientAppImpl to require callbackUrl if window is undefined.
    • Removed _sendVerificationEmail method from _StackClientAppImpl.
  • Functions:
    • Modified sendVerificationEmail in _StackServerAppImpl to require callbackUrl if window is undefined.
  • Misc:
    • Updated type definitions for sendForgotPasswordEmail and sendMagicLinkEmail to include optional callbackUrl.

This description was created by Ellipsis for 5f1fa44. It will automatically update as commits are pushed.

@vercel Vercel
Copy link

vercel bot commented Dec 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stack-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 6:27pm
stack-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 6:27pm
stack-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 6:27pm

N2D4
N2D4 approved these changes Dec 12, 2024
View reviewed changes
packages/stack/src/lib/stack-app.ts Outdated Show resolved Hide resolved
@N2D4 N2D4 changed the title Fixed the problem that some of the server functions require windows Add callbackUrl to all functions that require a callback URL Dec 12, 2024
@N2D4 N2D4 mentioned this pull request Dec 12, 2024
Closed
@fomalhautb fomalhautb merged commit 76ad55d into dev Dec 12, 2024
13 checks passed
@fomalhautb fomalhautb deleted the fix-server-functions branch December 12, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellipsis-dev ellipsis-dev[bot] ellipsis-dev[bot] left review comments

@N2D4 N2D4 N2D4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG(stack/packages/stack/src/utils/url.tsx): Client-only constructRedirectUrl is called by StackServerApp
2 participants
@fomalhautb @N2D4