Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neon webhook create #368

Merged
merged 5 commits into from
Dec 12, 2024
Merged

Neon webhook create #368

merged 5 commits into from
Dec 12, 2024

Conversation

fomalhautb
Copy link
Contributor

@fomalhautb fomalhautb commented Dec 12, 2024


Important

Adds Neon webhook creation route, refactors Svix client usage, and updates tests and ESLint rules.

  • New Feature:
    • Adds POST route in route.tsx for creating Neon webhooks using getSvixClient.
  • Refactoring:
    • Replaces direct Svix instantiation with getSvixClient in svix-token/route.tsx and webhooks.tsx.
  • Testing:
    • Adds webhooks.test.ts to test Neon webhook creation.
    • Updates snapshot-serializer.ts to strip secret field in snapshots.
  • Linting:
    • Fixes ESLint rule in defaults.js for yupString URL validation.

This description was created by Ellipsis for 28dd696. It will automatically update as commits are pushed.

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stack-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 6:21pm
stack-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 6:21pm
stack-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 6:21pm

@fomalhautb fomalhautb marked this pull request as ready for review December 12, 2024 04:27
@@ -8,6 +8,13 @@ import { Result } from "@stackframe/stack-shared/dist/utils/results";
import { Svix } from "svix";
import * as yup from "yup";

export function getSvixClient(projectId: string) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The projectId parameter in getSvixClient is unused and should be removed to avoid confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants