fix(spark-anomaly-detection): Adjust Trino HTTPS connection #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Techassi
changed the title
19 tasks
sbernauer
reviewed
Jul 16, 2025
demos/spark-k8s-anomaly-detection-taxi-data/setup-superset.yaml
Outdated
Show resolved
Hide resolved
NickLarsenNZ
requested changes
Jul 16, 2025
demos/spark-k8s-anomaly-detection-taxi-data/create-spark-anomaly-detection-job.yaml
Outdated
Show resolved
Hide resolved
demos/spark-k8s-anomaly-detection-taxi-data/create-spark-anomaly-detection-job.yaml
Outdated
Show resolved
Hide resolved
demos/spark-k8s-anomaly-detection-taxi-data/setup-superset.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Nick <[email protected]>
Co-authored-by: Nick <[email protected]>
13 tasks
razvan
reviewed
Jul 16, 2025
| - pipefail | ||
| - -c | ||
| - | | ||
| curl -L -o superset-assets.zip sets.zip https://raw.githubusercontent.com/stackabletech/demos/main/demos/spark-k8s-anomaly-detection-taxi-data/superset-assets.zip |
There was a problem hiding this comment.
Can you be more specific?
Is the indentation a problem? ie:
Suggested change
| curl -L -o superset-assets.zip sets.zip https://raw.githubusercontent.com/stackabletech/demos/main/demos/spark-k8s-anomaly-detection-taxi-data/superset-assets.zip | |
| curl -L -o superset-assets.zip sets.zip https://raw.githubusercontent.com/stackabletech/demos/main/demos/spark-k8s-anomaly-detection-taxi-data/superset-assets.zip |
There was a problem hiding this comment.
the sets.zip is too much and it looks like a left over that breaks the curl output
NickLarsenNZ
added a commit
that referenced
this pull request
Jul 16, 2025
There was a problem hiding this comment.
We should remember to copy this zip to other demos that have one (though I'm unsure if they are all equal).
NickLarsenNZ
added a commit
that referenced
this pull request
Jul 17, 2025
* fix(demo/trino-taxi-data): Use new listener service * fix(demo/trino-taxi-data): Use updated superset config - See: #251 * chore: Bump Trino worker by 2GB RAM * fix(demo/trino-taxi-data): Disable ANALYZE step - See: trinodb/trino#26214
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
superset-assets.zipwithhttp_scheme: "https"in order to avoid the HTTP/HTTPs problems when using the Trino connection