-
-
Notifications
You must be signed in to change notification settings - Fork 7
chore(trino): Bump trino ahead of 25.7.0 #1095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bddca8c
to
91abb66
Compare
de747c7
to
825d7cf
Compare
825d7cf
to
f4ac4ee
Compare
Also remove the git hack for patchable and instead skip gitcommitid like we do for druid and rearrange the command into multiple lines with additional skips
--batch-mode \ | ||
--no-transfer-progress \ | ||
package \ | ||
`# -Dmaven.test.skip # Unable to skip test compilation without an unused dependency error for software.amazon.awssdk:identity-spi` \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pointing out that we cannot skip compilation yet, else we hit this issue:
[ERROR] Unused declared dependencies found:
[ERROR] software.amazon.awssdk:identity-spi:jar:2.31.57:compile
Slack thread discussing whether to patch out the unused dependency, or just continue compiling tests even though we skip running them.
I'll mark this comment as resolved after approval
Build succeeds (also tested 470):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Probably want to patch out the tech debt introduced in 471. |
It went missing during a merge in #1095
It went missing during a merge in #1095
Part of #1082
476
(don't forget the patches)455
Definition of Done Checklist
Note
Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.
Please make sure all these things are done and tick the boxes
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
bake
to retrieve the image tag for<image-tagged-with-the-major-version>
.