Skip to content

fix(trino): Reactivate the commitid plugin, otherwise tests fail #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2025
Merged

fix(trino): Reactivate the commitid plugin, otherwise tests fail #1160

merged 1 commit into from
Jun 11, 2025

Conversation

NickLarsenNZ
Copy link
Member

Part of #1082.

Fixes tests that require the version in SQL queries (and likely the version being displayed in the web UI).

Reverts back to what @sbernauer had done in #881

@NickLarsenNZ NickLarsenNZ self-assigned this Jun 11, 2025
@NickLarsenNZ NickLarsenNZ moved this to Development: Waiting for Review in Stackable Engineering Jun 11, 2025
@NickLarsenNZ NickLarsenNZ enabled auto-merge June 11, 2025 15:19
@lfrancke lfrancke moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 11, 2025
lfrancke
lfrancke approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@lfrancke lfrancke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future we can just patch the POM I guess

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Jun 11, 2025
Merged via the queue into main with commit aa344f2 Jun 11, 2025
3 checks passed
@NickLarsenNZ NickLarsenNZ deleted the fix/trino-commitid-plugin branch June 11, 2025 15:26
@NickLarsenNZ NickLarsenNZ moved this from Development: In Review to Development: Done in Stackable Engineering Jun 11, 2025
@NickLarsenNZ
Copy link
Member Author 

--- PASS: kuttl (538.39s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_trino-451_hive-4.0.1_opa-1.4.2_hdfs-3.4.1_zookeeper-3.9.3_openshift-false (538.37s)
PASS

@NickLarsenNZ NickLarsenNZ mentioned this pull request Jun 12, 2025
Closed
14 tasks
@sbernauer
Copy link
Member

Thanks past me to add a test for this to the smoke tests :)

@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfrancke lfrancke lfrancke approved these changes

Assignees

@NickLarsenNZ NickLarsenNZ

Labels
None yet
Projects
Stackable Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NickLarsenNZ @sbernauer @lfrancke