Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hbase): remove dependency on htrace #820

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

razvan
Copy link
Member

@razvan razvan commented Aug 29, 2024

Description

Part of #816

Relevant comment: #816 (comment)

Images are building successfully: https://github.com/stackabletech/docker-images/actions/runs/10664458546

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Tasks

TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@razvan razvan mentioned this pull request Aug 30, 2024
5 tasks
@razvan razvan changed the title fix(hbase): remove dependency on jackson-databind 2.4.0 fix(hbase): remove old jackson-databind dependency from Phoenix Aug 30, 2024
@razvan razvan marked this pull request as ready for review September 2, 2024 09:23
@razvan razvan requested a review from a team September 2, 2024 09:24
CHANGELOG.md Outdated Show resolved Hide resolved
hbase/README.md Outdated Show resolved Hide resolved
@NickLarsenNZ
Copy link
Member

NickLarsenNZ commented Sep 10, 2024

Re: the hadolint failure, I stumbled across this today: https://www.docker.com/blog/introduction-to-heredocs-in-dockerfiles/

Maybe we need to update the syntax for the Dockerfile for hadolint to accept the heredoc?


Although, there is already an issue for hadolint: hadolint/hadolint#806

@razvan razvan marked this pull request as draft September 10, 2024 12:00
@razvan
Copy link
Member Author

razvan commented Sep 10, 2024

Converted to draft again, since:

  • we are now removing htrace completely and not just jackson-databind 2.4.0
  • is wip

@razvan razvan changed the title fix(hbase): remove old jackson-databind dependency from Phoenix fix(hbase): remove dependency on htrace Sep 10, 2024
@@ -36,7 +36,7 @@
"java-base": "11",
"java-devel": "11",
"async_profiler": "2.9",
"phoenix": "5.3.0-4afe457",
"phoenix": "5.3.0-ca21a87dd6",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment next to this to show where it comes from?

Also, common short-hash is 7 characters long (unless there is a new recommendation to avoid collisions)?

Suggested change
"phoenix": "5.3.0-ca21a87dd6",
"phoenix": "5.3.0-ca21a87", # This is currently manually built and uploaded to Nexus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants