Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nifi): update versions for 24.11 #868

Merged
merged 3 commits into from
Sep 19, 2024
Merged

chore(nifi): update versions for 24.11 #868

merged 3 commits into from
Sep 19, 2024

Conversation

razvan
Copy link
Member

@razvan razvan commented Sep 16, 2024

Description

part of #836

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Tasks

TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

NickLarsenNZ
NickLarsenNZ previously approved these changes Sep 19, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a note about a comment that seems a bit off.

nifi/versions.py Show resolved Hide resolved
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@razvan razvan added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit e831252 Sep 19, 2024
2 checks passed
@razvan razvan deleted the chore/nifi-24.11 branch September 19, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants